Skip to content
This repository was archived by the owner on Feb 4, 2025. It is now read-only.

fix(prow/plugins/approve): support get approvers when used full config#32

Merged
wuhuizuo merged 3 commits into
releasefrom
feature/fix-approve-plugin-2
Jun 29, 2023
Merged

fix(prow/plugins/approve): support get approvers when used full config#32
wuhuizuo merged 3 commits into
releasefrom
feature/fix-approve-plugin-2

Conversation

@wuhuizuo
Copy link
Copy Markdown
Member

@wuhuizuo wuhuizuo commented Jun 27, 2023

What

Fixed: kubernetes#7690

Ref:

How

  • Make it be fixed without massive refactoring, and not change the behavior and approve notifies.

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@ti-chi-bot ti-chi-bot Bot added size/L and removed size/M labels Jun 27, 2023
@wuhuizuo wuhuizuo force-pushed the feature/fix-approve-plugin-2 branch from 91bd37a to 0f00a19 Compare June 29, 2023 03:41
@wuhuizuo wuhuizuo merged commit a95a424 into release Jun 29, 2023
@ti-chi-bot ti-chi-bot Bot deleted the feature/fix-approve-plugin-2 branch June 29, 2023 05:46
@wuhuizuo wuhuizuo restored the feature/fix-approve-plugin-2 branch June 29, 2023 05:46
wuhuizuo added a commit that referenced this pull request Sep 11, 2023
#32)

Fixed: kubernetes#7690

Ref:
- PingCAP-QE/ee-ops#621

- Make it be fixed without massive refactoring, and not change the
behavior and approve notifies.

---------

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

approve plugin makes assumptions about OWNERS file implementation

1 participant